conn.py performance improvements, make examples work, add another example #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.timeout = timeout | ||
| self._sock.settimeout(self.timeout) | ||
| self._dirty = False | ||
| self._sock = None |
There was a problem hiding this comment.
No need to set _socket here since it's set in reinit()
There was a problem hiding this comment.
self._sock is required because the first line of reinit() asks "if not self._sock"
There was a problem hiding this comment.
Ah you mean in close(). You're right
added 4 commits
February 25, 2014 16:51
|
looks good to me |
dpkp
added a commit
that referenced
this pull request
Mar 22, 2014
conn.py performance improvements, make examples work, add another example
wbarnha
added a commit
to alfaix/kafka-python
that referenced
this pull request
Mar 10, 2024
…pkp#134) wakeup When wakeup() is called, we sometime notice that we get an endless prints: "Unable to send to wakeup socket!". Those prints are spamming the logs. This commit aims to address it by allowing restating the application via an intentional exception raise. This behavior is configurable and its default is backward compatible. Signed-off-by: shimon-armis <shimon.turjeman@armis.com> Co-authored-by: shimon-armis <shimon.turjeman@armis.com>
bradenneal1
pushed a commit
to bradenneal1/kafka-python
that referenced
this pull request
May 16, 2024
…pkp#134) wakeup When wakeup() is called, we sometime notice that we get an endless prints: "Unable to send to wakeup socket!". Those prints are spamming the logs. This commit aims to address it by allowing restating the application via an intentional exception raise. This behavior is configurable and its default is backward compatible. Signed-off-by: shimon-armis <shimon.turjeman@armis.com> Co-authored-by: shimon-armis <shimon.turjeman@armis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change consists of: